How I Review Pull Requests

many hats: copy, consistency, naming, semantics, dry

How to review pull-requests

How I do PR comments:

  1. Is the PR small enough and contains documentation for what is done?
  2. Look at the context
  3. Look at the patterns (is there logic in controllers, views?, are patterns followed)
  4. Is the code self-explanatory?
  5. Does it follow DRY, KISS?