How I Review Pull Requests
many hats: copy, consistency, naming, semantics, dry
How to review pull-requests
How I do PR comments:
- Is the PR small enough and contains documentation for what is done?
- Look at the context
- Look at the patterns (is there logic in controllers, views?, are patterns followed)
- Is the code self-explanatory?
- Does it follow DRY, KISS?